DillerDigitalStudents/DD-SWNG-20251020-V
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement Unit Testing for fancymath #8

Merged
TimDiller merged 17 commits from unit_tests into main 2025-10-24 17:10:59 +00:00
Conversation 2 Commits 17 Files Changed 6
+106
TimDiller commented 2025-10-24 15:06:41 +00:00
Owner
Copy Link
Copy Source
No description provided.
TimDiller added 4 commits 2025-10-24 15:06:42 +00:00
initial commit test suite 922ed4d394
make test folder importable 56c892d944
tests for is_even and is_odd 6d98c08e89
add tests for adding Vectors 6ba84c9859
TimDiller marked the pull request as work in progress 2025-10-24 15:07:08 +00:00
david.moody added 1 commit 2025-10-24 15:08:54 +00:00
add test_dot_product to test_vector.py 352480ac14
TimDiller added 1 commit 2025-10-24 15:19:27 +00:00
add test for proper failure of Vector.dot 4d5e2db71a
TimDiller added 4 commits 2025-10-24 15:25:28 +00:00
Add cross-product and tests 13ac74132c
Merge branch 'unit_tests' into enh/cross-product 64f06ce7c1
Add cross product impleimentation 437be17f51
Merge pull request 'Add cross-product and tests' (#9) from enh/cross-product into unit_tests 491c531ed8 
Reviewed-on: http://git.dillerdigital.com/DillerDigitalStudents/DD-SWNG-20251020-V/pulls/9
TimDiller added 5 commits 2025-10-24 15:42:58 +00:00
Add unit test for Vecotr.abs method 35a1705570
Add unit test for Vector.abs b613241807
Corrected syntax for vecotr.abs() test 79b6c10b70
Merge branch 'unit_tests' into unit_tests_ambar 5850743394
Merge pull request 'unit_tests_ambar' (#10) from unit_tests_ambar into unit_tests 913169fe68 
Reviewed-on: http://git.dillerdigital.com/DillerDigitalStudents/DD-SWNG-20251020-V/pulls/10
Reviewed-by: Tim Diller <tim@dillerdigital.com>
TimDiller added 2 commits 2025-10-24 16:09:12 +00:00
Add subtests for test_cross_product. 66123f6064
Merge pull request 'Add subtests for test_cross_product.' (#11) from test/vector-cross-subtests into unit_tests aa7dc496dc 
Reviewed-on: http://git.dillerdigital.com/DillerDigitalStudents/DD-SWNG-20251020-V/pulls/11
Reviewed-by: Tim Diller <tim@dillerdigital.com>
TimDiller requested review from ambar 2025-10-24 16:59:34 +00:00
TimDiller requested review from corran 2025-10-24 16:59:34 +00:00
TimDiller requested review from david.moody 2025-10-24 16:59:34 +00:00
corran reviewed 2025-10-24 17:05:35 +00:00
corran left a comment
Member
Copy Link
Copy Source

This looks pretty good. We should have type checking on other in the __add__ method and a few more docstrings would be good. Beyond that there are some design issues to consider, but they may not need to be part of this PR.

This looks pretty good. We should have type checking on `other` in the `__add__` method and a few more docstrings would be good. Beyond that there are some design issues to consider, but they may not need to be part of this PR.
src/fancymath/vector.py
@@ -30,6 +30,20 @@ class Vector(object):
s = "Vector(x=%s, y=%s, z=%s)" % (self.x, self.y, self.z)
return s
def __add__(self, other):
corran commented 2025-10-24 17:03:05 +00:00
Member
Copy Link
Copy Source

This should handle case where other is not a Vector.

This should handle case where `other` is not a `Vector`.
src/fancymath/vector.py
@@ -33,0 +37,4 @@
return self.__class__(x, y, z)
def __mul__(self, other):
if not isinstance(other, Vector):
corran commented 2025-10-24 17:03:53 +00:00
Member
Copy Link
Copy Source

Do we want to handle scalar multiplication here? If so we should implement __rmul__ and __imul__.

Do we want to handle scalar multiplication here? If so we should implement `__rmul__` and `__imul__`.
test/test_vector.py
@@ -0,0 +53,4 @@
def test_dot_product(self):
v1 = Vector(1, 2, 3)
v2 = Vector(-3, -2, -1)
v3 = v1.dot(v2)
corran commented 2025-10-24 17:02:31 +00:00
Member
Copy Link
Copy Source

Seeing this in use, perhaps we should use @ for dot product? So we get v1 @ v2. Can we open an issue to discuss this?

Seeing this in use, perhaps we should use `@` for dot product? So we get `v1 @ v2`. Can we open an issue to discuss this?
TimDiller marked the pull request as ready for review 2025-10-24 17:08:27 +00:00
david.moody commented 2025-10-24 17:09:37 +00:00
Member
Copy Link
Copy Source

The operation for cross product using '*' would confuse users who want to multiply vectors.

The operation for cross product using '*' would confuse users who want to multiply vectors.
TimDiller merged commit e3ffd2210b into main 2025-10-24 17:10:59 +00:00
TimDiller deleted branch unit_tests 2025-10-24 17:10:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
ambar
david.moody
corran
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
TimDiller (Tim Diller) admin ambar (Ambar de Santiago) corran (Corran Webster) david.moody (David Moody)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DillerDigitalStudents/DD-SWNG-20251020-V#8